[TYPO3-core] RFC #9474: Integrate OpenID authentication support to TYPO3

[Xavier Perseguers]

Hi there,

>> line 34:
>> please use names for the variables that tell what information they 
>> contain, even if that information is not needed at this point.
> 
> There's something wrong. I assume you refer to the main part of this 
> extension: sv1 service. Line 34 there is:
> 
> *  221:     protected function includePHPOpenIDLibrary()
> 
> So it does not fit.
> 
> On many issues about variable names I think they are already good and 
> descriptive enough. I do not plan to change them. You can make a patch 
> to perfect variables, why not? This is personal taste, everyone has its 
> own and it is not bad :) We all can start renaming variables of others 
> (I already spotted some of yours that I'd like to rename) ;) But I doubt 
> it adds much value and makes our work effective, so I will not do it.
> 
> The time spent on this feature was large and I do not plan to invest any 
> more, unless I need to fix obvious bugs there. I am really sorry but I 
> truly do not have time for changing variable names. Other work is 
> planned and I must do that now.
> 
> We can have this patch pending until someone posts an updated patch (and 
> we test it again thoroughly, this is necessary!) or we commit as is now 
> and you can rename variables later. I do not see any other realistic ways.

Just to mention that unlike another (big) patch that eventually went to 
trunk (or didn't it finally?), this OpenID patch was throughout tested 
(by myself) and it really works now. It is fully functional and it 
really would be a pity that such a good feature would be kept here 
forever. Please Ingo give your initial +1 and let other people create 
the patch that will rename variables if you think it cannot be kept as 
it is.

There are many other patches pending in this list that fix troubles and 
that are not discussed because of the lack of time, please focus on 
higher valuable stuff. There's many bugs but a great community which 
proactively send bug fixes. Core members should reward them by applying 
them patches (or slightly modified if needed) ASAP.

Thanks.

-- 
Xavier Perseguers
http://xavier.perseguers.ch/en