[TYPO3-core] RFC #9474: Integrate OpenID authentication support to TYPO3

[Dmitry Dulepov]

Hi!

Ingo Renner wrote:
> here's my review:
> 
> line 34:
> please use names for the variables that tell what information they 
> contain, even if that information is not needed at this point.

There's something wrong. I assume you refer to the main part of this extension: sv1 service. Line 34 there is:

 *  221:     protected function includePHPOpenIDLibrary()

So it does not fit.

On many issues about variable names I think they are already good and descriptive enough. I do not plan to change them. You can make a patch to perfect variables, why not? This is personal taste, everyone has its own and it is not bad :) We all can start renaming variables of others (I already spotted some of yours that I'd like to rename) ;) But I doubt it adds much value and makes our work effective, so I will not do it.

The time spent on this feature was large and I do not plan to invest any more, unless I need to fix obvious bugs there. I am really sorry but I truly do not have time for changing variable names. Other work is planned and I must do that now.

We can have this patch pending until someone posts an updated patch (and we test it again thoroughly, this is necessary!) or we commit as is now and you can rename variables later. I do not see any other realistic ways.

-- 
Dmitry Dulepov
TYPO3 Core team
My TYPO3 book: http://www.packtpub.com/typo3-extension-development/book
In the blog: http://typo3bloke.net/post-details/iphone_as_productivity_tool/