[TYPO3-core] RFC: #9674: TCEmain changes for new improved record recycling concept

Xavier Perseguers typo3 at perseguers.ch
Sat Nov 15 16:20:17 CET 2008


Hi,

This is no +1 or -1 on feature itself but comments after reading 
regarding the patch itself:

- new code does not respect CGL (parenthese next to the "if" w/o blank 
space, no space before curly brace, ...)

- Description of method canUndeleteRecord is wrong. It does not return a 
boolean but a string, which is not obvious from the method name. 
"canSomething" should return TRUE or FALSE, not a message.

- Please fix the first word of the comment of the method after 
canUndeleteRecord ("Beford" instead of "Before")

-- 
Xavier Perseguers
http://xavier.perseguers.ch/en


More information about the TYPO3-team-core mailing list