[TYPO3-core] RFC: #8205: Shortcut ends in parse_url-error

[Jeff Segars]

Christian Kuhn wrote:
> Hi.
> 
> Rob Vonk wrote:
>> Steffen Kamper wrote:
>>> i attached new version against latest rev
> 
> +1 on testing for both 4.2 and trunk.
> 
> 
>> I tried running the patch on a fresh 4.2.2 and trunk version but it gives 
>> errors on both systems.
> 
> 
> - trunk had one (unimportant) failing hunk, attached file
> 8205_shortcut4.diff fixes this.
> 
> - 4.2-branch has a whitespace issue in alt_clickmenu.php leading to
> failing hunk #6, attached version 8205_shortcut4_4.2.diff handles this.
> 
> 
> No logic change in both files in comparison to Steffens latest
> 8205_shortcut3.diff.
> 
> 
> Cheers
> Christian
> 

+1 based on reading, pending two comments that Steffen and I discussed 
on Skype.

In the function removeHost(), only the hostname is removed and not any 
subdirectory where TYPO3 may be running. For better portability, we 
could use TYPO3_SITE_URL to remove the whole path.

I would also be in favor of creating a wrapper method for rawurlencode 
(JS version) that removes the host info rather than adding an optional 
argument.  Currently, the optional argument is used every single time 
rawurlencode is called in the core so an additional method would 
probably make the code more readable.  No functional change with this 
one, of course.

Thanks!
jeff