[TYPO3-core] RFC: #8205: Shortcut ends in parse_url-error

[Steffen Kamper]

Hi Jeff,

thx for looking at.

I changed the patch according your advices
* remove TYPO3_SITE_URL
* used a new JS-function called rawurlencodeAndRemoveSiteUrl for better 
readability

Additional i added spaces according CGL

vg Steffen


Jeff Segars schrieb:
> 
> +1 based on reading, pending two comments that Steffen and I discussed 
> on Skype.
> 
> In the function removeHost(), only the hostname is removed and not any 
> subdirectory where TYPO3 may be running. For better portability, we 
> could use TYPO3_SITE_URL to remove the whole path.
> 
> I would also be in favor of creating a wrapper method for rawurlencode 
> (JS version) that removes the host info rather than adding an optional 
> argument.  Currently, the optional argument is used every single time 
> rawurlencode is called in the core so an additional method would 
> probably make the code more readable.  No functional change with this 
> one, of course.
> 
> Thanks!
> jeff

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 8205_shortcut4.diff
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20081104/5d078412/attachment-0001.txt