[TYPO3-core] RFC #8509: Some labels in Module About are hardcoded

Martin Kutschker martin.kutschker-n0spam at no5pam-blackbox.net
Fri May 30 10:59:37 CEST 2008


Christopher schrieb:
> Hi,
> 
> 
> 
> this is my first SVN patch request. :-)
> 
> 
> 
> Type: Bugfix / New feature
> 
> 
> 
> Bugtracker references:
> 
> http://bugs.typo3.org/view.php?id=8509
> 
> 
> 
> Branches:
> 
> TYPO3_4-1, TYPO3_4-2 and trunk.
> 
> 
> 
> Problem:
> 
> In the About-Module there are some texts which still are hardcoded.

This module has it's own xml file "locallang_mod_help_about.xml"

> 
> --- typo3/sysext/lang/locallang_core.xml-orig	2008-04-23 12:15:40.000000000 +0200
> +++ typo3/sysext/lang/locallang_core.xml	2008-05-27 23:07:29.000000000 +0200
> @@ -87,8 +87,8 @@
>  			<label index="labels.setAllCheckboxes">Select All Checkboxes</label>
>  			<label index="labels.changeInOrig">Changed in original translation</label>
>  			<label index="labels.expandAll">Expand all</label>
> - 			<label index="labels.new_section">Create new:</label>
> - 			<label index="labels.count">Quantity:</label>
> +			<label index="labels.new_section">Create new:</label>
> +			<label index="labels.count">Quantity:</label>

What has been changed here?

>  			<label index="ver.online">ONLINE</label>
>  			<label index="ver.mgm">Version Management</label>
>  			<label index="ver.selVer">Select version:</label>
> @@ -190,12 +190,23 @@
>  			<label index="cm.moveFolder_into">Move folder into</label>
>  			<label index="cm.createNewRelation">Create new relation</label>
>  			<label index="warning.install_password">The Install Tool is still using the default password &quot;joh316&quot;. Update this within the %sAbout section%s of the Install Tool.</label>
> -			<label index="warning.backend_admin">The default backend user "admin" with password &quot;password&quot; is still present. %sEdit this account%s, either deleting it completely or changing the username and password.</label>
> +			<label index="warning.backend_admin">The default backend user &quot;admin&quot; with password &quot;password&quot; is still present. %sEdit this account%s, either deleting it completely or changing the username and password.</label>
>  			<label index="warning.install_enabled">The Install Tool is enabled. Delete the file &quot;%s&quot; when you have finished setting up TYPO3.</label>
>  			<label index="warning.install_enabled_cmd">Click to remove the file now!</label>
>  			<label index="warning.install_encryption">The encryption key is not set. Set it in the %sBasic Configuration section%s of the Install Tool.</label>
>  			<label index="warning.install_update">This installation is not configured for the TYPO3 version it is running. If you did so intentionally, this message can be safely ignored. If you are unsure, visit the %sUpdate Wizard%s section of the Install Tool to see how TYPO3 would change.</label>
>  			<label index="warning.backend_reference">The Reference Index table is empty which is likely the result of a recent TYPO3 upgrade. Please go to %sTools&gt;DB Check%s and update the reference index.</label>
> +			<label index="about.information">TYPO3 Information</label>
> +			<label index="about.community_credits">Community Credits</label>
> +			<label index="about.information_detail">If you want to know why TYPO3 rocks, have a look at this page:</label>
> +			<label index="about.extension_authors">Extension Authors</label>
> +			<label index="about.extension_list_info">This is a list of the people who contributed to the extensions you're using in your installation.</label>
> +			<label index="about.extension">Extension</label>
> +			<label index="about.extension_author">Author</label>
>  		</languageKey>
>  	</data>
> -</T3locallang>
> +	<orig_hash type="array">
> +	</orig_hash>
> +	<orig_text type="array">
> +	</orig_text>
> +</T3locallang>
> \ No newline at end of file

Please make your patch as clean as possible. You have a change up there 
" => &quot; (might be considered a fix) and some clutter at the end of it.

Masi


More information about the TYPO3-team-core mailing list