[TYPO3-core] RFC #8509: Some labels in Module About are hardcoded
Christopher
Chrissitopher at gmx.de
Fri May 30 14:12:38 CEST 2008
Hi Martin,
have a look at version 3:
"Martin Kutschker" <martin.kutschker-n0spam at no5pam-blackbox.net> schrieb im
Newsbeitrag
news:mailman.1.1212137977.15866.typo3-team-core at lists.netfielders.de...
> Christopher schrieb:
>> Hi,
>>
>>
>>
>> this is my first SVN patch request. :-)
>>
>>
>>
>> Type: Bugfix / New feature
>>
>>
>>
>> Bugtracker references:
>>
>> http://bugs.typo3.org/view.php?id=8509
>>
>>
>>
>> Branches:
>>
>> TYPO3_4-1, TYPO3_4-2 and trunk.
>>
>>
>>
>> Problem:
>>
>> In the About-Module there are some texts which still are hardcoded.
>
> This module has it's own xml file "locallang_mod_help_about.xml"
Ohh, OK. I have now included the changes there.
>
>>
>> --- typo3/sysext/lang/locallang_core.xml-orig 2008-04-23
>> 12:15:40.000000000 +0200
>> +++ typo3/sysext/lang/locallang_core.xml 2008-05-27 23:07:29.000000000
>> +0200
>> @@ -87,8 +87,8 @@
>> <label index="labels.setAllCheckboxes">Select All Checkboxes</label>
>> <label index="labels.changeInOrig">Changed in original
>> translation</label>
>> <label index="labels.expandAll">Expand all</label>
>> - <label index="labels.new_section">Create new:</label>
>> - <label index="labels.count">Quantity:</label>
>> + <label index="labels.new_section">Create new:</label>
>> + <label index="labels.count">Quantity:</label>
>
> What has been changed here?
Nothing, I changed it back.
>
>> <label index="ver.online">ONLINE</label>
>> <label index="ver.mgm">Version Management</label>
>> <label index="ver.selVer">Select version:</label>
>> @@ -190,12 +190,23 @@
>> <label index="cm.moveFolder_into">Move folder into</label>
>> <label index="cm.createNewRelation">Create new relation</label>
>> <label index="warning.install_password">The Install Tool is still using
>> the default password "joh316". Update this within the %sAbout
>> section%s of the Install Tool.</label>
>> - <label index="warning.backend_admin">The default backend user "admin"
>> with password "password" is still present. %sEdit this
>> account%s, either deleting it completely or changing the username and
>> password.</label>
>> + <label index="warning.backend_admin">The default backend user
>> "admin" with password "password" is still present.
>> %sEdit this account%s, either deleting it completely or changing the
>> username and password.</label>
>> <label index="warning.install_enabled">The Install Tool is enabled.
>> Delete the file "%s" when you have finished setting up
>> TYPO3.</label>
>> <label index="warning.install_enabled_cmd">Click to remove the file
>> now!</label>
>> <label index="warning.install_encryption">The encryption key is not set.
>> Set it in the %sBasic Configuration section%s of the Install
>> Tool.</label>
>> <label index="warning.install_update">This installation is not
>> configured for the TYPO3 version it is running. If you did so
>> intentionally, this message can be safely ignored. If you are unsure,
>> visit the %sUpdate Wizard%s section of the Install Tool to see how TYPO3
>> would change.</label>
>> <label index="warning.backend_reference">The Reference Index table is
>> empty which is likely the result of a recent TYPO3 upgrade. Please go to
>> %sTools>DB Check%s and update the reference index.</label>
>> + <label index="about.information">TYPO3 Information</label>
>> + <label index="about.community_credits">Community Credits</label>
>> + <label index="about.information_detail">If you want to know why TYPO3
>> rocks, have a look at this page:</label>
>> + <label index="about.extension_authors">Extension Authors</label>
>> + <label index="about.extension_list_info">This is a list of the people
>> who contributed to the extensions you're using in your
>> installation.</label>
>> + <label index="about.extension">Extension</label>
>> + <label index="about.extension_author">Author</label>
>> </languageKey>
>> </data>
>> -</T3locallang>
>> + <orig_hash type="array">
>> + </orig_hash>
>> + <orig_text type="array">
>> + </orig_text>
>> +</T3locallang>
>> \ No newline at end of file
>
> Please make your patch as clean as possible. You have a change up there "
> => " (might be considered a fix)
Fixed.
> and some clutter at the end of it.
Also fixed.
Christopher
==============================================================================
--- typo3/mod/help/about/index.php-orig 2008-05-30 13:47:15.000000000 +0200
+++ typo3/mod/help/about/index.php 2008-05-30 13:50:58.000000000 +0200
@@ -107,19 +107,19 @@
<div id="typo3-mod-help-about-index-php-outer">
<img src="'.$BACK_PATH.'gfx/typo3logo.gif" width="123" height="34"
vspace="10" alt="TYPO3 logo" />
<div class="typo3-mod-help-about-index-php-inner">
- <h2>TYPO3 Information</h2>
+
<h2>'.$GLOBALS['LANG']->sL('LLL:EXT:lang/locallang_mod_help_about.xml:information').'</h2>
<h3>'.$LANG->getLL('welcome',1).'</h3>
<p>'.$minorText.'</p>
</div>
<div class="typo3-mod-help-about-index-php-inner">
- <h2>Community Credits</h2>
- <p>Visit <a href="http://typo3.org/community/"
target="_blank">typo3.org/community</a> if you want to know why TYPO3
rocks.</p>
+
<h2>'.$GLOBALS['LANG']->sL('LLL:EXT:lang/locallang_mod_help_about.xml:community_credits').'</h2>
+
<p>'.$GLOBALS['LANG']->sL('LLL:EXT:lang/locallang_mod_help_about.xml:information_detail').'
<a href="http://typo3.org/community/"
target="_blank">typo3.org/community</a></p>
</div>
<div class="typo3-mod-help-about-index-php-inner">
- <h2>Extension Authors</h2>
- <p>This is a list of the people who contributed to the extensions
you\'re using in your installation.</p>
+
<h2>'.$GLOBALS['LANG']->sL('LLL:EXT:lang/locallang_mod_help_about.xml:extension_authors').'</h2>
+
<p>'.$GLOBALS['LANG']->sL('LLL:EXT:lang/locallang_mod_help_about.xml:extension_list_info').'</p>
<p><br />'.$this->getExtensionAuthors().'</p>
</div>
</div>
@@ -143,7 +143,7 @@
* @return string list of extensions authors and their e-mail
*/
function getExtensionAuthors() {
- $content = '<table border="0" cellspacing="2"
cellpadding="1"><tr><th>Extension</th><th>Author</th></tr>';
+ $content = '<table border="0" cellspacing="2"
cellpadding="1"><tr><th>'.$GLOBALS['LANG']->sL('LLL:EXT:lang/locallang_mod_help_about.xml:extension').'</th><th>'.$GLOBALS['LANG']->sL('LLL:EXT:lang/locallang_mod_help_about.xml:extension_author').'</th></tr>';
$loadedExtensions = $GLOBALS['TYPO3_LOADED_EXT'];
foreach ($loadedExtensions as $extensionKey => $extension) {
@@ -184,4 +184,4 @@
$SOBE = t3lib_div::makeInstance('SC_mod_help_about_index');
$SOBE->main();
$SOBE->printContent();
-?>
+?>
\ No newline at end of file
=======================================================
--- typo3/sysext/lang/locallang_mod_help_about.xml-orig 2008-05-30
13:46:20.000000000 +0200
+++ typo3/sysext/lang/locallang_mod_help_about.xml 2008-05-30
13:46:03.000000000 +0200
@@ -6,8 +6,15 @@
</meta>
<data type="array">
<languageKey index="default" type="array">
+ <label index="information">TYPO3 Information</label>
<label index="welcome">TYPO3 Professional Web Content Management
System</label>
<label index="minor">TYPO3 is a flexible and professional Open Source
Web-CMS based on PHP and MySQL.<br /><br />TYPO3 is
<b>freely available</b> under the <a
href="http://typo3.com/1316.0.html"
target="_blank">TYPO3-license (GNU/GPL)</a>.<br
/><br />%s %s<br /></label>
+ <label index="community_credits">Community Credits</label>
+ <label index="information_detail">If you want to know why TYPO3 rocks,
have a look at this page:</label>
+ <label index="extension_authors">Extension Authors</label>
+ <label index="extension_list_info">This is a list of the people who
contributed to the extensions you're using in your installation.</label>
+ <label index="extension">Extension</label>
+ <label index="extension_author">Author</label>
<label index="mlang_labels_tablabel">About TYPO3</label>
<label index="mlang_labels_tabdescr">Displays the basic facts about the
TYPO3 application, version and licensing terms.</label>
<label index="mlang_tabs_tab">About</label>
More information about the TYPO3-team-core
mailing list