[TYPO3-core] RFC: #8515: Speed up tslib_cObj->getTreeList by caching its results

Dmitry Dulepov [typo3] dmitry at typo3.org
Mon May 26 12:24:22 CEST 2008


Hi!

Oliver Klee wrote:
> - Do we really need to store the cache in the DB or would a cache in a 
> static variable suffice?

My question as well. It may be useful for USER_INT extensions to have such information in cache. But for USER it is mostly irrelevant. In any case storing in database does not hurt, so I am neutral on this.

> Some issue concerning coding style (as decided upon in the CGL session):

In addition I remember old CGL said that files in tslib/ has tslib_ prefix. The added class is not strictly in tslib/ (it is one directory below) but it may be more consistent to call it  tslib_treelistCacheUpdate instead of tx_cms_treelistCacheUpdate. I do not insist. Just thoughts. I am all in favor of tx_ everywhere but mixing tx_cms_ and tslib_ does not look good.

Patch is big I am looking to the code. Could not find any issues by looking. It should be a big advantage to have it in core!

-- 
Dmitry Dulepov
TYPO3 core team
Web: http://typo3bloke.net/
"Nothing is impossible. There are only limits to our knowledge"


More information about the TYPO3-team-core mailing list