[TYPO3-core] Core and CGL

Dmitry Dulepov [typo3] dmitry at typo3.org
Mon Jul 21 12:43:39 CEST 2008


Hi!

Steffen Kamper wrote:
> we always have discussions / nitpickings with CGL-issues in patches.
> The problem for anyone who writes patches is the mix of styles in the 
> core files.
> So when you change some lines you should also change the surrounding 
> ones? It looks strange to have this mixture.

I am ok with slow changes. To me a function looks like a unit to reformat when changing it. Of course, reformatting something as huge as process_datamap() would be a big task by itself.

I would not like to reformat the whole t3lib_TCEmain if I am to do a tiny patch there :)

> So i see the need to change all core files to CGL, so we don't need to 
> split patches for CGL etc. Ingo told about a possibility to do that 
> automatically with eclipse, is that still possible? This would make the 
> work so much easier!

We should use extdeveval. It can reformat files. But extdeveval should be adjusted first to fit latest CGL.

-- 
Dmitry Dulepov
TYPO3 Core team
More about TYPO3: http://typo3bloke.net/
Subscribe: http://typo3bloke.net/rss.xml
Latest article: http://typo3bloke.net/post-details/nominate_me_as_typo3_mvp/


More information about the TYPO3-team-core mailing list