[TYPO3-core] RFC: t3editor: a bunch of bugfixes and code clean up

[Tobias Liebig]

This is an SVN patch request.


Problem(s):

* BF: tab feature in textarea missed when deactivate the t3editor >
reported by Franz Koch in typo3.dev

* improve use of prototype libary
  * remove unneeded browserchecks
  * use Form.request instead of building an own Ajax-request

* BF: Operators < > and = don't get colored correctly, but highlighted
as "values"

* BF: undo/redo feature causes some errors and don't work like ecspected
(sorry vitaly - thanks for your work on this - we will re-introduce this
feature in the next release!)

* BF: t3editor got totally broken in the new backend in 4.2b1. > Bug #7442

* BF: saving w/ ajax don't work when clicking the "save"-icon in the
document header (input type=submit got replaced by type=image in the new
backend)

* BF: wrong line count when t3editor initializes if last line have no
trailing linefeed

* BF: when typing HTML-Tags and hit RETURN they get "applied" > reported
by Franz Koch in typo3.dev

* BF: t3editor is not usable on IPhone/iPod-Touch and should be disabled

* BF: t3editor is not available in "constants"

* BF: typo(s) in code and comments

* BF: saving w/ Ajax cause special code to srew up (send with wrong
encoding) > Bug #6812
	this is a prototype-related problem
	see: http://dev.rubyonrails.org/ticket/2151

* code clean up
	which actually mean touching almost every single line.
	this is why this patch is that huge
	but without this cleanup, reviewing the
	"codemirror"-code is really a hard job


Solution:
the attached patch


Notes:
I know we should not post that huge patches which solves that many bugs
and i (very much) apologize for that.
I hope its nevertheless acceptable, as the t3editor is just intruduced
with 4.1 and the whole code is not reviewed yet


Notes II:
Thomas offered his help to review the t3editor code, and i'm grateful
for that.
To everyone else: Please help to review and test the editor to make sure
it's stable when we ship 4.2

Thanks!

Branches:
TYPO3_4-2, Trunk

regards
  Tobias


-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch_t3editor_20080209a.diff
Type: text/x-patch
Size: 243293 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080209/bc07d12f/attachment-0001.bin