[TYPO3-core] RFC: #9167: Feature: Mark extension as write protected

[Steffen Kamper]

Dmitry Dulepov [typo3] schrieb:
> Hi!
> 
> Steffen Kamper wrote:
>> Type: Feature
>>
>> Bugtracker reference: http://bugs.typo3.org/view.php?id=9167
>>
>> Branches: trunk
>>
>> Problem:
>> There are cases where you have to modify extensions. But as soon as 
>> someone updates the extension the modification is gone.
>>
>> Solution:
>> This patch introduces the state "write_protected"
>> As soon you set this for an extension in em_conf, it will be shown in 
>> EM list, update feature is disabled (for check for updates and import)
>>
>> See screenshots as i did this with comments extension.
> 
> The idea is good but there are few notes.
> 
> There lots of non-modified line in the patch :( Hard to see what was 
> really changed. Can you clean it up? If you use command-line diff, "-w" 
> will help. Or you may choose an option to ignore whitespace change in 
> your other diff application.
> 
> I see you added coloring. I am against that. Colors should be defined by 
> skin only.
> 
> The property is logically boolean. So use true/false. We should be more 
> strict about such things.
> 
> Also strings seems to be hard-coded, which we do not this anymore...
> 

Hi Dmitry,

i see your points, but whole EM is terrible from the code. Colors are 
all hardcoded, Strings are all hardcoded. So i concentrated on the 
functional. There should be a run for
a) move hardcoded strings to locallang
b) move colors to stylesheet
c) cleanup code
b) maybe rewrite the whole thing
IIRC you had a simular problem with one of your latest patches.

I removed white space changes and one forgetten debug, so attached patch 
shows the real changes

vg Steffen
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: extension_write_protected2.diff
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080814/7b8db67c/attachment.txt