[TYPO3-core] FYI: Icon for new_file.gif

Dmitry Dulepov [typo3] dmitry at typo3.org
Wed Apr 16 14:19:41 CEST 2008


Benni,

firsts, you and Ingo must be sure: I think you are doing great job! I am not against any of you, anything in your job or any of these icons! I only want the comitting process of comitting to be adjusted a little. I think it is easy to do! Read on.

Benjamin Mack wrote:
> 1. I did not commit any top level module icons here.

File module - wasn't it for File module? At least Ingo tried to commit new icon for Web>Functions.

> 2. I did a change in t3skin after discussing this with Jens yesterday
> and with Ingo this morning (so basically, yeah, there are two +1 offlist
> even if there is NO functionaly code change). I don't know if you have
> ever had a look into the t3skin/icons/gfx directory. The initial author
> COPIED many icons from the oldskin in there and now this is a total mess
> stylewise, which I tried to clean up. If you use t3skin you completely
> know that this change is neither a functional change, but something I
> would call a serious "visual bug" that existed since the creation of 
> t3skin.

I am not against new icons (as I said earlier). I am against any automatic commits of GUI changes. Plus I am against of committing of icons here and there. Please, make a package and show it! Otherwise it is impossible to get a picture of the final result. Can you guarantie that we will not have 30% of old, 30% of new and 40% of silk icons?

This GUI change, so it is important for editors. They had some problems with new GUI recently and I would like to make transition to new GUI to be more smooth. I am sure it is your wish as well! We are on the same side.

> 3. It's not like these icons just came up here, we all had Jens' 
> proposals for a while now, and AFAIK there was no clear statement from 
> you about them yet. I talked with Jens about the icons and will continue 
> to do so during T3DD08 for the other icons that will come 4.3 to make 
> them ready for the core. When we agreed to not completely integrate the 
> icons in 4.2, we decided to add some that did not make sense at all (and 
> yes, the amount of icons that go in 4.2 depends on how much we discuss 
> over it in this list after the ). Unfortunately, the t3skin has been 
> left out for quite some time now until late last year.

I told Jens I like them. But I am ok with replacing them all at once, not just two icons here and one there. It makes GUI looking incomplete.

> So, for a icon change that there was a crappy one before, I do not only
> need the approval from the HCI - Team (which I considered to be a part 
> of, but always get the "please check with Jens before" from this list 
> here, where Jens then responds that the change is ok as it was his idea 
> initially), but then, I need another two +1s ON the list for this 
> non-functional change. Then I get a "well, I don't like it that way, 
> because my editors are not used it, let's take my version of the icon 
> etc." --- it takes way too much unnecessary efforts to get this going.

Well, I would not be that pedantic. But I would happy if you post here with words "If no one objects, I will commit it by end of the day". It gives chance others to look at it. The more eyes - the better! You can get even more +1s ;)

> I would even consider to have a "FYI24: This icon / change will be 
> commited in 24h if no vetos or better solutions are coming", with no BT 
> entry or RFC needed. Something like that, we can think about it on T3DD08.

He-he, I wrote paragraph above and read yours :) Glad we have similar views!

-- 
Dmitry Dulepov
TYPO3 core team
Web: http://typo3bloke.net/
Skype: callto:liels_bugs
"Nothing is impossible. There are only limits to our knowledge"


More information about the TYPO3-team-core mailing list