[TYPO3-core] Patches to be approved for the core

Kasper Skårhøj kasper2007 at typo3.com
Sun Oct 28 13:40:48 CET 2007


I'll commit it now.


- kasper



On Oct 24, 2007, at 10:16 , Ingmar Schlecht wrote:

> Hi Kasper,
>
> Kasper Skårhøj wrote:
>> Not to be impatient or anything, but I'm trying to follow the rules  
>> of
>> the list and get even my own patches reviewed like everyone else.
>>
>> - So either I'm in the back of the line
>> - Or you don't think I need your permission
>> - Or I don't follow the rules (and should post to the bugtracker).
>>
>> The problem is I have no time to be administrative about this. Alone
>> dividing them into five files has been enough for me. So I would
>> actually like to ask the list if I can just commit these one by one  
>> with
>> the assumption that you trust the quality of my code and I can  
>> therefore
>> bypass the usual game rules a bit. Otherwise the next time I will  
>> have
>> time is 28th of January...
>
> Please just commit the stuff as is, I will do cleanup work as part  
> of my
> (temporary) core-team leadership job later on.
>
> That way we assure the code gets tested in Alpha 2 and we have  
> plenty of
> time left for bugfixing.
>
> Before committing, please:
> - remove all commented-out code
> - add JavaDoc documentation to the last parameter of
>   getSingleField_typeFlex_draw
> - Remove the strange character from // Nów, we generate  
> "templates"
>   in patch_flexforms.diff
>
> cheers
> Ingmar
>
> -- 
> Ingmar Schlecht
> TYPO3 Association Active Member
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
>
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.netfielders.de
> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-core

- kasper

-----------------------------------------------------
How many women does it take to get a baby in 1 month?

Kasper Skårhøj
Tryggevældevej 8
2720 Vanløse
+45 20 999 115
skype : kasperskaarhoej




More information about the TYPO3-team-core mailing list