[TYPO3-core] Patches to be approved for the core

Ingmar Schlecht ingmar at typo3.org
Wed Oct 24 10:16:45 CEST 2007


Hi Kasper,

Kasper Skårhøj wrote:
> Not to be impatient or anything, but I'm trying to follow the rules of
> the list and get even my own patches reviewed like everyone else.
> 
> - So either I'm in the back of the line
> - Or you don't think I need your permission
> - Or I don't follow the rules (and should post to the bugtracker).
> 
> The problem is I have no time to be administrative about this. Alone
> dividing them into five files has been enough for me. So I would
> actually like to ask the list if I can just commit these one by one with
> the assumption that you trust the quality of my code and I can therefore
> bypass the usual game rules a bit. Otherwise the next time I will have
> time is 28th of January...

Please just commit the stuff as is, I will do cleanup work as part of my
(temporary) core-team leadership job later on.

That way we assure the code gets tested in Alpha 2 and we have plenty of
time left for bugfixing.

Before committing, please:
 - remove all commented-out code
 - add JavaDoc documentation to the last parameter of
   getSingleField_typeFlex_draw
 - Remove the strange character from // Nów, we generate "templates"
   in patch_flexforms.diff

cheers
Ingmar

-- 
Ingmar Schlecht
TYPO3 Association Active Member


More information about the TYPO3-team-core mailing list