[TYPO3-core] RFC: Fix bug #6121: formmail: reply-to can contain invalid characters if formMailCharset different from site charset

Michael Stucki michael at typo3.org
Wed Oct 17 12:26:01 CEST 2007


Hi Masi,

>> Well, I _did_ try to change it, but came to a much larger change which is
>> harder to test and harder to understand than the current one-liner is.
>> The real solution though seems to be a complete rewrite of this method
>> which I still don't like anyways...
>> 
>> So, since v2 works fine, I suggest to stick with this one and let you
>> care (if you do) about the second patch.
>> 
>>> Apart from that +1 from reading (also for the nont described second fix:
>>>> = instead of >).
>> 
>> Oh yes, I forgot to mention that. Actually I was not sure if this is
>> needed or not (I think it's not) but it seems logical that this was not
>> changed at the 2nd place by accident.
> 
> Ok, then commit the original patch - maybe you can think of a little
> comment that warns about the 2nd reuse of $val.

Thanks. Committed to TYPO3_4-1 and Trunk.

- michael
-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug_6121_v3.diff
Type: text/x-diff
Size: 2566 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20071017/cc40668f/attachment.diff 


More information about the TYPO3-team-core mailing list