[TYPO3-core] RFC: Fix bug #6121: formmail: reply-to can contain invalid characters if formMailCharset different from site charset

[Martin Kutschker]

Michael Stucki schrieb:
> Hi Masi,
> 
>> Ok, but I suggest to use a different tmp. variable then $val. $val ist
>> reused all the time and anyone tyring to move the replyto_name code around
>> will break things.
> 
> I agree with you, but I didn't like to add more variables here. See below
> what happens otherwise...
> 
> Well, I _did_ try to change it, but came to a much larger change which is
> harder to test and harder to understand than the current one-liner is.
> The real solution though seems to be a complete rewrite of this method which
> I still don't like anyways...
> 
> So, since v2 works fine, I suggest to stick with this one and let you care
> (if you do) about the second patch.
> 
>> Apart from that +1 from reading (also for the nont described second fix:
>>> = instead of >).
> 
> Oh yes, I forgot to mention that. Actually I was not sure if this is needed
> or not (I think it's not) but it seems logical that this was not changed at
> the 2nd place by accident.

Ok, then commit the original patch - maybe you can think of a little 
comment that warns about the 2nd reuse of $val.

Masi