[TYPO3-core] REMINDER [Fwd: RFC: #3493 IFSUB problems]
Martin Kutschker
martin.kutschker-n0spam at no5pam-blackbox.net
Mon Oct 8 23:16:13 CEST 2007
Martin Kutschker schrieb:
> Wolfgang Klinger schrieb:
>> REMINDER (with new patch against current trunk):
>>
>> -------- Original Message --------
>> Subject: [TYPO3-core] RFC: #3493 IFSUB problems
>> Date: Thu, 31 Aug 2006 11:59:54 +0200
>> From: Wolfgang Klinger <wolfgang at stufenlos.net>
>> Reply-To: TYPO3 core team <typo3-team-core at lists.netfielders.de>
>> To: TYPO3 core team <typo3-team-core at lists.netfielders.de>
>>
>>
>> *hiya!*
>>
>> http://bugs.typo3.org/view.php?id=3493
>>
>> The method ifSub of tslib_menu does not check the pages with the
>> current language and had some other flaws in the past.
>>
>> This patch should solve everything because it relies on another method
>> that does exactly the same checks as currently plus some more
>> (what was missing until yet)
>
> I was about to test it, but stumbled upon #6420 and now I'm too tired.
> But after checking tslib_menu I think the fix is correct.
I also noticed that filterMenuPages() is using at one point
intval($GLOBALS['TSFE']->config['config']['sys_language_uid']) instead
of $GLOBALS['TSFE']->sys_language_uid. Is there a reason?
Masi
PS: Does anyone know how much time TYPO3 wastes with repeated trim()s
and intval()s it does just to be on the safe side?
More information about the TYPO3-team-core
mailing list