[TYPO3-core] Tabbed menus as a separate class file

Tapio Markula tapio.markula at xetpoint.fi
Sun Nov 18 13:25:03 CET 2007


Benjamin Mack kirjoitti:
> Hey Tapio,
> 
> good idea.
> 
> a) the js file should be put in "t3lib/js" and be named "tabmenu.js"

currenlty all JS-files are in the t3lib folder - there is not yet 
subfolder /js. If changed to subfolder, then *all* Js-files in t3lib 
should be moved from t3lib to t3lib/js

> b) I think we can merge the "warningicons" class into the 
> t3lib_iconworks class since there is only one function in it.

iconworks has in 4.1.3 seven functions - not much anyway and most 
function are relative small. Reasonable proposal.

> c) call the PHP class "t3lib_tabmenu".

no it has functions, which relate with two kind of tabmenus - that's why 
  I gave the name 't3lib_tabmenus' instead of 't3lib_tabmenu'

> d) also, I'd rename the functions like t3lib_tabmenu::getDynTabMenu to 
> something else, to like "get" or "getDynamic" since everybody knows what 
> you'll get since we put it in an extra class.

I didn't change because it is easier to use the correct method, if the 
method name has not changed


More information about the TYPO3-team-core mailing list