[TYPO3-core] RFC: Bug 1537: shortcut icon syntax incorrect/incomplete

Martin Kutschker martin.kutschker-n0spam at no5pam-blackbox.net
Sun May 20 10:43:31 CEST 2007


Ingo Renner schrieb:
> This is a SVN patch request.
> 
> Problem:
> The html code for shortcut/fav icons is not correct / incomplete
> 
> Solution:
> modify it to be more compatible
> 
> Comments:
> After some research I couldn't find a clear definition but suggestions 
> to add both versions of html code to maximize compatibility. Although it 
> is often recommended to use .ico files other images types (jpeg, gif, 
> png, bmp) do work. Becuase of that I think simply adding image/x-icon as 
> mime type would be wrong. mime_content_type can be used to determine the 
> correct mime type if available, the newer Fileinfo PECL extension is 
> rare I guess so that it doesn't make much sense to use it...

mime_content_type() is deprecated and TYPO3 has already mime type 
guessing routines, although not in t3lib_div. It is not present in my 
5.5.2 (testes with the CLI version).

Anyway if you think we should add the mime type we must provide a 
fallback - at least for .ico files.

Masi


More information about the TYPO3-team-core mailing list