[TYPO3-core] RFC:Bug 1347 Indexed search browselist relies on javascript

Thorsten Kahler thorsten.kahler at dkd.de
Wed Mar 21 22:41:51 CET 2007


Hi Masi,

Martin Kutschker wrote on 16.03.2007 17:01:
>> Switch between mode using plugin.tx_indexedsearch.browseLinks_setUrl in TS.
> 
> Why do we need the switch? If there is any advantage in the JS code for 
> the use let's use both, if not we can drop the JS thingy altogether. 
> Having the real anchor as fallback is always good. So is we need a 
> config I'd add a plugin.tx_indexedsearch.browseLinks_disableJS. If set 
> only href is set, if not both href and onclick are active.

I see the point in your arguments but would nevertheless prefer the
suggested way. The original code produced only the JS variant and AFAIR our
policy says we shouldn't change any output just for style reasons or the
likes. So my proposal adds the option to change the output, but doesn't
change it by default or even disables the previous output

> Just my 2c (patch untested).
> 
> +1 on the *idea*

The patch I added to bug 1347 was meant just as that: a patch. I'd still
prefer the improvement mentioned in comment 10644: use submit buttons for
every page and include the pagination in the search form.

Regards
Thorsten


-- 

Thorsten Kahler
. . . . . . . . . . . .
Je TYPO3, desto d.k.d

d.k.d Internet Service GmbH
Kaiserstr. 79
D - 60329 Frankfurt / Main

Registergericht: Amtsgericht Frankfurt am Main
Registernummer: HRB 45590
Geschäftsführer: Olivier Dobberkau, Götz Wegenast.

fon:  +49 (0)69 43 05 61 - 70
fax:  +49 (0)69 43 05 61 - 90
mail: thorsten.kahler at dkd.de
home: http://www.dkd.de

Aktuelle TYPO3-Projekte:
www.dosb.de  Relaunch
www.gesundheit.de  Relaunch
www.wwf.de  barrierefrei, Relaunch


More information about the TYPO3-team-core mailing list