[TYPO3-core] bug in getBorderAttr()

Michael Scharkow mscharkow at gmx.net
Wed Nov 9 13:36:12 CET 2005


rupert germann wrote:

> I can't confirm this. are we talking about the same patch?
> my suggestion:
> if (!(t3lib_div::inList('xhtml_strict,xhtml_11,xhtml_2',
> $GLOBALS['TSFE']->config['config']['doctype']) || 
> $GLOBALS['TSFE']->config['config']['disableImgBorderAttr'])) {
>         return $borderAttr;
> }
> 
> Ernestos suggestion:
> if (!t3lib_div::inList('xhtml_strict,xhtml_11,xhtml_2',
> $GLOBALS['TSFE']->config['config']['doctype']) || 
> !$GLOBALS['TSFE']->config['config']['disableImgBorderAttr']) {
>         return $borderAttr;
> }

Actually, Ernesto's suggestion is more like:
if (!t3lib_div::inList('xhtml_strict,xhtml_11,xhtml_2', 
$GLOBALS['TSFE']->config['config']['doctype']) && 
!$GLOBALS['TSFE']->config['config']['disableImgBorderAttr']) {

And *then* both are equivalent, as pointed out in 
http://bugs.typo3.org/view.php?id=1461

Rupi, sorry for the confusion. I guess I've missed some chars when 
fiddling with this. I agree that Ernesto's version seems more grokable.

+1 from me

Cheers,
Michael




More information about the TYPO3-team-core mailing list