[TYPO3-core] bug in getBorderAttr()

rupert germann rupi at gmx.li
Wed Nov 9 13:00:40 CET 2005


On Tuesday 08 November 2005 18:55, Michael Scharkow wrote:
> -1 because the patch does not seem to fix the problem, or introduces
> others:
>
> I do get borders with this patch and
>
> doctype = xhtml_11
> disableImgBorderAttr = 1

I can't confirm this. are we talking about the same patch?

my suggestion:
if (!(t3lib_div::inList('xhtml_strict,xhtml_11,xhtml_2',
$GLOBALS['TSFE']->config['config']['doctype']) || 
$GLOBALS['TSFE']->config['config']['disableImgBorderAttr'])) {
        return $borderAttr;
}

Ernestos suggestion:
if (!t3lib_div::inList('xhtml_strict,xhtml_11,xhtml_2',
$GLOBALS['TSFE']->config['config']['doctype']) || 
!$GLOBALS['TSFE']->config['config']['disableImgBorderAttr']) {
        return $borderAttr;
}

both patches will give the same result but Ernestos version is easier to read 
so I suggest to take this one.

greets
Rupert



More information about the TYPO3-team-core mailing list