[TYPO3-core] bug in getBorderAttr()

Michael Scharkow mscharkow at gmx.net
Tue Nov 8 18:55:03 CET 2005


rupert germann wrote:
> Hi Folks,
> 
> (this time with the correct email address *g*)
> 
> Here is a small CVS patch request.
> 
> Type: Bugfix
> 
> Description:
> The new function 'getBorderAttr' I added to tslib_content for removing 
> 'border="0"' from img-tags doesn't work as it should. 
> The patch fixes the problem.

-1 because the patch does not seem to fix the problem, or introduces others:

I do get borders with this patch and

doctype = xhtml_11
disableImgBorderAttr = 1

plus Ernesto found another strange effect and reported it 
http://bugs.typo3.org/view.php?id=1360

I can say that Ernesto's patch works for me, so I attach it here for 
review.

For the record: I still think the whole thing is a very dirty hack and 
we should drop border attribs altogether. But if we use this condition, 
we have to use it in more places, e.g. GMENUs still have border attribs, 
etc. I will make another proposal for that issue.

Greetings,
Michael

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: getBorder_fix.diff
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20051108/9cdfd9a9/attachment.diff 


More information about the TYPO3-team-core mailing list