[TYPO3-v4] Mr. Jenkins will complain about CGL issues

Stefano Kowalke blueduck at gmx.net
Wed Apr 20 15:48:48 CEST 2011


Am 19.04.11 22:44, schrieb Christian Kuhn:
> Hey,
> 
> On 04/19/2011 05:25 PM, Stefano Kowalke wrote:
>> This is all very new to him and he is a little bit nervously to do all
>> things right. Please contact me here or file a report at [1] if Mr.
>> Jenkins is too strictly with reviewing.
> 
> nice thing! I've already pushed a patched a second time to fix some
> things ;)
> 
> There is a detail Mr. Jenkins doesn't like, but I can not fix this:
> Patch set 5 on https://review.typo3.org/#change,1647
> He complains about not using self:: for a static method call in own
> class. But this method is a lambda function (the first one in core,
> btw), calling its 'parent' for recursion. Unfortunatly, lambda function
> can not use 'self' :)

I searched around, but I didn't found anything about using self:: from
inside a closure. Can you point me to a explanation?

Anyway, i filed a issue report at [1]. I will remove the -1 from your patch.

Stefano

[1] http://pear.php.net/bugs/bug.php?id=18465


More information about the TYPO3-project-v4 mailing list