[TYPO3-v4] Mr. Jenkins will complain about CGL issues

[Ernesto Baschny [cron IT]]

Hi Stefano,

sounds very cool!

I must confess that I cannot understand anything in the ci server. You
probably know "your way around", but there are so many links so many
icons, "builds", etc.. Where is the "manager report" where I can see
stuff at one glance? There are lots of fancy graphs, info and graphs
about "disk usage".. Then there is a test with "48284 warnings". I guess
new tests will be a "diff" to this one?

Maybe you could create some kind of "walk-through" for Jenkins newbies,
because I fear probably others feel the same.

Then some things I *was* able to figure out, and here is my feedback:

Type ValidCommentLineLength mentions "80 chars limit" for comments.
There is no rule about it in our CGL. We tend to keep it simple and
"around" 130 chars to sake of it.

Category CharacterAfterPHPClosingTag: "No newline character is allowed
after php closing tag; expect " ?> " but found " ?>\n ". This is not a
bug, but allowed as of the CGL. Different IDE's do it automatically and
it doesn't hurt the resulting output (PHP ignores it).

Type DisallowElseIfConstruct: is not relevant for us

Other than that it looks fine so far! Let's see it working in the future
reviewing.. :)

Cheers,
Ernesto

Stefano Kowalke schrieb am 19.04.2011 17:25:
> Hi,
> 
> in last few days Mr. Jenkins study our Coding Guidelines while he
> sitting in the sun and drinking some delicous coffee. Now he feels ready
> to check a lot of rules when he reviews your patch.
> 
> This is all very new to him and he is a little bit nervously to do all
> things right. Please contact me here or file a report at [1] if Mr.
> Jenkins is too strictly with reviewing.
> 
> You can see at [2] which rules taken into account. (On the left side)
> 
> Kind regards
> Mr. Jenkins aka Stefano
> 
> [1] http://forge.typo3.org/projects/team-php_codesniffer/issues
> [2] http://ci.typo3.org/view/TYPO3/view/Core/job/typo3-v4-core-testing/