[TYPO3-dev] EXT Extension uploader (extension_uploader) - no upload to TER

[Michael Schams]

On 11/09/13 20:24, Jigal van Hemert wrote:

[...]
>> If the new version of TER [1] has been installed on typo3.org recently,
>> it is possible that EXT:extension_uploader [2] does not work any more. I
>> reported this on forge: http://forge.typo3.org/issues/51645
[...]
> Can you explain why this should be a bug in TER and not in Extension
> Uploader?

I expected this question ;-) ...and it's quite legitimate. It took me a 
while to dig into the code, before I decided, I create a patch for TER 
and not for EXT:extension_uploader.

When EU (Extension Uploader) creates $data for the SOAP request, which 
includes the TYPO3 dependency, it sends the dependencies as an object, 
which I think is legitimate (the WSDL file does not specify this due to 
the cascading).

See file "Classes/Upload/ExtensionDataCollector.php"
Methods getDataForExtension() and getDependenciesArray()

So, from TER's view, it receives a SOAP call such as:

uploadExtension ($accountData, $extensionInfoData, $filesData)

Where $extensionInfoData can be something like:

$extensionInfoData->technicalData->dependencies

...and type: stdClass (not array only).

My patch allows both data types: array and stdClass. If the SOAP request 
contains a dependency of type stdClass (object), it converts it to an 
array and then processes it as usual.

> Furthermore, TER returns an error description. This is shown in the EM,
> but apparently not in Extension Uploader. This seems also a bug to me in
> that tool.

That's right and very annoying. However, not relevant to this discussion :-)

> What do you think?

I think, I am not a hard-core developer and not the author of 
EXT:extension_uploader. I am happy to be proven wrong if my approach is 
not ideal.

But I would also like to enable the TYPO3 community to publish their 
extensions at TER (again) as soon as possible - given the fact TYPO3 
version 6.0 and 6.1 does not offer such a function out-of-the-box, which 
means, we rely on CLI tools, the TER frontend and external extensions 
such as EXT:extension_uploader.


Cheers
Michael