[TYPO3-dev] Including email addresses of reviewers in commits

[Ernesto Baschny]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Steffen,

Steffen Gebert schrieb am 30.12.2013 13:39:

> like since the beginning of our Gerrit history, we have a patch [1]
> in our custom Gerrit build included that removes the email address
> of the reviewers from the commits made by Gerrit (see e.g. in [2]
> the Reviewed-By lines).
> 
> To my knowledge this was added (removed) because some people 
> complained that their email addresses are published in the commit 
> messages.
> 
> However, starting with Gerrit 2.8 (released ~2 months ago), we 
> wouldn't need custom Gerrit builds anymore, if we could also get
> rid of this customization.
> 
> Thus I suggest do also drop this patch and just include the mail 
> addresses (like it is also done for the Author/Committer
> attributes).
> 
> Is there a majority that is NOT happy with including them?

I personally have no problem with it, since my email is visible in so
many places already.

But I see a difference to the commiter/author: The author/commiter are
the ones that we might need to contact in case of some trouble (i.e.
licensing, copyright, patent, etc...), while we will never need to
contact the Reviewers and Testers. So there is no gain in having this
information disclosed in the commit message.

But, since this eases future deployment and "streamlines" our
infrastructure by using the original Gerrit Code, I would endorse
changing that.

To make that clear to everyone using our infrastructure, we should add
a disclaimer somewhere when registering on typo3.org (or when using
Gerrit?).

Currently, when you "sign in" at typo3.org it will only display the
register form in the popup, without any further information. After
clicking around, you can find this page:

http://typo3.org/my-account/sign-up/

This text is too short, old and misleading ("Email addresses are
always spam-protected, so don't worry about spam too much"). The email
addresses are already shown at forge.typo3.org without any "spam
protection".

So I would suggest the editorial team to rephrase this a bit and maybe
streamline this registration process a bit (with more explanations).


> P.S: I have no ETA for a Gerrit 2.8 upgrade, but want to have this 
> issue negotiated in advance. Gerrit 2.8 brings one major change
> with what I'm personally not so happy with (the new Change Screen
> UI, which is however optional). As they also switched the build
> system (from Maven to Buck), this could be a good opportunity, if
> we don't need to use the new build system at all.

Makes sense, and I am glad the server team is doing such an amazing
job in keeping the services runing and up-to-date as much as it is
possible with the limited resources. Thanks!

Cheers,
Ernesto

- -- 
Ernesto Baschny
TYPO3 CMS Core Developer
Release Manager TYPO3 4.5 & 6.2 LTS

TYPO3 .... inspiring people to share!
Get involved: typo3.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: GnuPT 2.6.2.1 by EQUIPMENTE.DE
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlLBoGMACgkQHHDui5FfZDigjwCdFEJTfEeQMLCps02U8k4OPHn0
OSoAn0fg+FhIbhfK7w+Cr+b8x/GM8Pku
=VWB1
-----END PGP SIGNATURE-----