[TYPO3-dev] Including email addresses of reviewers in commits

[Steffen Gebert]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all,

like since the beginning of our Gerrit history, we have a patch [1] in
our custom Gerrit build included that removes the email address of the
reviewers from the commits made by Gerrit (see e.g. in [2] the
Reviewed-By lines).

To my knowledge this was added (removed) because some people
complained that their email addresses are published in the commit
messages.

However, starting with Gerrit 2.8 (released ~2 months ago), we
wouldn't need custom Gerrit builds anymore, if we could also get rid
of this customization.

Thus I suggest do also drop this patch and just include the mail
addresses (like it is also done for the Author/Committer attributes).

Is there a majority that is NOT happy with including them?

Thanks for your feedback!

Kind regards
Steffen

P.S: I have no ETA for a Gerrit 2.8 upgrade, but want to have this
issue negotiated in advance. Gerrit 2.8 brings one major change with
what I'm personally not so happy with (the new Change Screen UI, which
is however optional). As they also switched the build system (from
Maven to Buck), this could be a good opportunity, if we don't need to
use the new build system at all.
- -- 
[1]
https://github.com/TYPO3-infrastructure/gerrit/commit/6f1df910e6ff169fc29642d19785683b3b866a3c
[2]
https://git.typo3.org/Packages/TYPO3.CMS.git/commit/f8fdcea7949a5c71f6078f7dda76f08881f56c01

Steffen Gebert
TYPO3 Server Administration Team Member

TYPO3 .... inspiring people to share!
Get involved: http://typo3.org

My wish list:
https://www.amazon.de/registry/wishlist/922E3JYSQ7CV/ref=cm_wl_sb_v?sort=priority
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJSwWlyAAoJEIskG/rSlyw4qNIIAMXNFRQnT7S/P1UNWGWlx9Sm
fx1w7FhUiH3zY42DoBnD2pJJDSkh58kezM/Lkaac+UUd5pRi+uqwc5InQIOws372
VgAqm1b3/3zlQGvKZbhW5Gdxs+/HyDl9/8i7gmNfJ9VIE0bh+yA3p6TstZnDbgr2
b4UHkOgB2oR5Mzw8ESYgsrIHoFjt+JzMiBZi4QQx5dxQJx6oO7uEXroTMphw7yZl
GdmZajUrF88OHcQQltmoRD6AQ/H2lQfOEBM7d/AR1+8ap/U1iJnT4xPKYhhm6rUf
h+UlUAC841uZDU2zWJXtKXnaLMs62kYE6ALhN+AZTdvNG9bZEAaaxTo2Oii7tu4=
=haJ7
-----END PGP SIGNATURE-----