[TYPO3-core] CGL, to dot or not to dot, this is the question

Alexander Opitz opitz at pluspol.info
Fri Oct 18 14:15:23 CEST 2013


Hi Jigal,

> 1. Changing it means a lot of changes. Not only in the core, but also in
> code sniffer (if it checks for that)

No one says, that you need to change the code from one to another day. 
And changing the code sniffer as blocker of change CGL was told me last 
time for removing the closing tag. But see, it has changed.

The jenkins code sniffing by patch and night doesn't check for the dot 
position. [1] [2]

Anyway, changing the phpcs ruleset isn't hard to do.

> 2. Flow CGL also puts it at the end of the first line [a]

I already wrote that Flow uses the same. On the other side, this rule 
was taken from the CMS CGL.

Greetings Alex//

[1] https://ci.typo3.org/job/typo3-v4-core-gerrit/
[2] https://ci.typo3.org/job/typo3-v4-core-nightly/

-- 
Alexander Opitz

PLUSPOL interactive GbR
Floßplatz 4
04107 Leipzig

Telefon:   (0341) 350 585 -19
Telefax:   (0341) 350 585 -40

E-Mail:    opitz at pluspol.info
Internet:  http://www.pluspol.info

Geschäftsführer:
Dipl. Medienwirt (FH) Jörg Brückner
Dipl.- Ing. (FH) Stefan Dittmar
Dipl.- Ing. (FH) Thomas Lange

USt-ID-Nr.: DE221591186

Sitz der Gesellschaft und Gerichtsstand ist Leipzig


More information about the TYPO3-team-core mailing list