[TYPO3-core] Explaination of reverted patches and an appeal for review

[Markus Klein]

Hello again!

Thanks a lot for the progress today.
[4] is already merged.

[5] has been reworked by Bernhard and also got functional tests for DataHandler. :-)
It would be great to get some votes also on this patch.

Cheers
Markus

------------------------------------------------------------
Markus Klein
TYPO3 CMS Active Contributors Team Member


> -----Original Message-----
> From: typo3-team-core-bounces at lists.typo3.org [mailto:typo3-team-core-
> bounces at lists.typo3.org] On Behalf Of Markus Klein
> Sent: Wednesday, November 20, 2013 1:13 PM
> To: 'TYPO3 core team'
> Cc: kraft at webconsulting.at
> Subject: [TYPO3-core] Explaination of reverted patches and an appeal for
> review
> 
> Dear contributors!
> 
> It has been quite a story last night.
> 
> Bernhard Kraft provided a patch [1], which is a great usability improvement.
> (pasting in page module in empty columns) It was reviewed by Wouter and
> me and after testing we decided to merge it.
> 
> Unfortunately I didn’t run the functional tests locally (which is no excuse),
> but fortunately we have a great Travis system, which does. +1 It discovered a
> severe bug in combination with versioning/workspaces.
> 
> It took me several hours debugging the functional tests, but I finally saw the
> obvious thing and suggested a fix in [2].
> But since the original patch involves changes in DataHandler, I finally decided
> to revert the original patch [3].
> 
> As a next step I split the original patch into two parts – since one part is just a
> Javascript change that actually fixes two things – and included my proposed
> fix.
> These parts are now available at [4] (which should be easy) and [5] (which
> depends on [4]).
> 
> Since usability is also a goal for 6.2, I kindly ask you to review the patches [4]
> and [5].
> And I kindly ask those experts on workspaces/DataHandler to have a look at
> [5] to make sure we don't break anything else.
> Nevertheless, IMHO we should risk to merge this to give usability a chance,
> otherwise I fear we will never merge this patch [5].
> 
> Thanks a lot!
> 
> Kind regards
> Markus
> 
> 
> [1] https://review.typo3.org/22201
> [2] https://review.typo3.org/25525
> [3] https://review.typo3.org/25527
> 
> [4] https://review.typo3.org/25531
> [5] https://review.typo3.org/25532
> 
> ------------------------------------------------------------
> Markus Klein
> TYPO3 CMS Active Contributors Team Member
> 
> 
> _______________________________________________
> Before posting to this list, please have a look to the posting rules on the
> following websites:
> 
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-core