[TYPO3-core] Explaination of reverted patches and an appeal for review

Bernhard Kraft kraftb at kraftb.at
Thu Nov 21 00:56:38 CET 2013


On 2013-11-20 13:13, Markus Klein wrote:
 > It took me several hours debugging the functional tests, but I
 > finally saw the obvious thing and suggested a fix in [2].
 > But since the original patch involves changes in DataHandler, I
 > finally decided to revert the original patch [3].

First of all there is redundant code in DataHandler. This is why I 
created the method "getLocalTCE()".

And for the other change: I assumed $value would NEVER be an array. I 
didn't knew that EXT:version is already exploiting this possibility.

When I created this patch I already played with the tought of 
implementing this feature as a hook (they get called all over the place 
there) but didn't do so because someone (I don't remember who) told me 
to keep things straight in the core.

So there are two possibilities right now:
1. Implement it directly into the core similarily like to what Markus
2. Don't touch the beauty of DataHandler.php (TCEmain) and implement it
    via a hook like in versioning, but in this case in EXT:backend.

Currently we are further working on approach 1


More information about the TYPO3-team-core mailing list