[TYPO3-core] RFC: CGL changes (closing php tag, multiline string concate)

Patrick Broens patrick.broens at typo3.org
Thu May 23 11:46:05 CEST 2013


On 22-5-13 20:49 , Jigal van Hemert wrote:
> Hi,
> On 22-5-2013 13:45, Alexander Opitz wrote:
>> 1) Remove closing PHP Tag and add one empty line
> This one comes up from time to time. There was no consensus during the
> last discussion and there were no convincing reasons pro or against.
>> 2) Change the multiline string concate from dot on last line to next
>> line and remove the extra indentation.
> This really doesn't solve any problem.
Right. IMHO it is strange an empty line at the end should be a rule.
I've tried several IDE's, and all of them remove the empty line by default.
> In general:
> - CGL mainly has the purpose to have a constant style of code
> formatting. This makes things easier to read
> - changing things in the CGL results in quite a bit of labour: core code
> needs to be changed and the code sniffer rules need to be adjusted
> So, unless there is very good reason to change CGL there won't be a lot
> of people enthusiastic about it.
I'm not ;-)
> At least a couple of the rules in the CGL I would have done differently
> if I had to set it up, but the most important thing is that it gives us
> a common code formatting that makes it easier to read and thus easier to
> spot problems.
Me too, but we've reached a consensus over some, which should not be
changed anymore, unless there is a very good reason for it.

Patrick Broens
TYPO3 Core Team member

TYPO3 .... inspiring people to share!
Get involved: typo3.org

More information about the TYPO3-team-core mailing list