[TYPO3-core] State of TYPO3 OpenID
christian.weiske at netresearch.de
Fri Jul 12 10:18:34 CEST 2013
> > Have a look at line 185 and following:
> >> // Here if user just started authentication
> >> $userRecord = $this->getUserRecord($this->openIDIdentifier);
> > This is the original. It fetches the user record from the database
> > instantly when the user gave the identifier. This fails in case of
> > generic endpoint identifiers.
> > I change this code to try to parse the url, and when this succeeds
> > and a protocol and host is set, the OpenID request is sent.
> > That way the OpenID login process is started before fetching the
> > user record.
> Does this help to solve the problem for Google users without Google+
Sigh. Yes, it does.
-- rant mode on --
If I wasn't very determined to get the OpenID fix into the core, I
would have given up quiet some time ago.
Helmut dismissed my patch saying that OpenID isn't meant to be used that
way and that we need two code paths, even though I know the OpenID spec
pretty well and implemented several OpenID clients before.
You made an alternative patch to mine without good reason for it,
probably without looking at my patch.
Then you dismiss my patch on the list based on cursory source review,
questioning its functionality without testing it. I explain myself
several times, and after all that exchange I get a "does it
solve the problem at all?" question in the end.
Heck, I made the patch to fix this exact issue. Yes, it does work here.
I've been talking about that one issue in the last month.
This is tedious.
Regards/Mit freundlichen Grüßen
-= Geeking around in the name of science since 1982 =-
More information about the TYPO3-team-core