[TYPO3-core] Review system woes

[Steffen Gebert]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I totally agree with Robert. Gerrit is only the tool that enables our
review workflow. We could also (almost..) do the same with Github - but
people have to count votes manually etc. Basically, that would be
similar to what we had in times of the RFCs in the core team mailing list.

Gerrit was introduced, because the manual overhead of the mailing list
was annoying and made core team members the bottleneck.
Well, isn't this what this thread is about? Still the Core Team members
are the bottleneck. Although Gerrit speeds up reviews, it doesn't bring
relief to a lack of time spent for reviews.

But I think that's pretty common for most widely used open source
projects. Just look at the issue trackers of other projects - there are
always loads of issues, when many people start to contribute. So I guess
that's not only a TYPO3 "problem", but just a negative side-effect of
accepting patches from the "outside" world.

Nevertheless, optimizing things is worth it.. so to join forces for
bringing big changes in, extending the core team with a couple of more
very active and diligent people (like Philipp), ask your boss for time
to improve TYPO3, etc. will bring TYPO3 forward. Complaining will not
help so much.

A big "optimization" is already that Christian Kuhn is working one day
per week paid by the T3A on reviews. That's already an amazing step,
which will for sure help us a lot!

Kind regards
Steffen

- -- 
Steffen Gebert
TYPO3 Server Administration Team Member

TYPO3 .... inspiring people to share!
Get involved: http://typo3.org

I work for TYPO3 solely in my spare time. If you think that
my work helps you running your business, you are invited to
send me a donation via PayPal to this email address. Thanks

On 2/8/13 2:36 PM, Robert Lemke wrote:
> 
> On 08.02.2013, at 14:04, Philipp Gampe <philipp.gampe at typo3.org> wrote:
> 
>> The reviewing is done to keep up high coding standards. In essence, this is 
>> pair programming light.
>>
>> Would you really want to bypass the review system (which is technical 
>> possible for any core dev anyway)?
>>
>> There have been some scary patches laying around. You surely would not want 
>> them to be included into the main tree.
>>
>> Also most non-trivial patches require more than one changeset, indicating 
>> that the overall quality is improved by the review system.
> 
> 
> +1
> 
> I might add that even patches by me or other of the Neos / Flow team which addressed
> issues in our own little parts of the code base contained some severe flaws in the past.
> 
> So, the problem is not so much the review system but rather the process and developer
> resources. If you anyone's idea is to omit reviews altogether, you have a different idea
> of quality assurance than I do.
> 
> Cheers,
> Robert
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.19 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJRF31fAAoJEIskG/rSlyw4F0EIALfJCaLgad0uUf6W3bwOg35/
O7BzoVJtPhj5uTJoTE85jQTLQhtHQH6tH+6KyXqtD/QH1K/zCBbt3Sof66K7Sh8R
uOMwnOKvRylEbvQgR/6HXPZqSlb1e2+k9Ni0eYlv8ZK96zVzFTgIniHVNeRLZp95
0TacCWVgsVvRzrUgMv0b6JapjrwvxCtN4A3UirN7vW55PewGurhVepGhKSfNGVQK
iJoJ5jZ+/URIx6BYCm0ICSsONaK0TnKBSudkefF/qtBEWR39UPHyRlhzNcls0J98
OQMSUSIWrXyqEpjcuVS2WVutcxvwSGirirkyq3XyCYwCv7WHefSKNSxaQQ9HBMY=
=f8Sz
-----END PGP SIGNATURE-----