[TYPO3-core] Review system woes

Jigal van Hemert jigal.van.hemert at typo3.org
Fri Feb 8 14:08:55 CET 2013


Hi,

On 8-2-2013 13:30, Daniel Alder wrote:
> "Verify: Needs two +1, one of them being a core developer"
> "As soon as the patch has reached the approved status, one core
> developer can decide to push the "Submit" button, finally pushing it to
> the main repository."
>
> ...in fact you need 2 core devs to reach all your goals with the money
> you spent ;) at least one (in case no-core-devs are doing the patches
> and reviews and "your" core dev is approving, since he can't do
> everything on his own)

The one who merges the patch (pushes the "Submit" button) can be same 
who did the review. In case the author was a core dev and the patch has 
positive reviews from another core dev plus anyone else, the author can 
merge it too.

If you merge it the backports become your responsibility (maybe you can 
ask someone else to do the backports and push these patches to the other 
branches).

-- 
Jigal van Hemert
TYPO3 Core Team member

TYPO3 .... inspiring people to share!
Get involved: typo3.org


More information about the TYPO3-team-core mailing list