[TYPO3-core] Review system woes

[Helmut Hummel]

Hi!

Am 08.02.13 11:43, schrieb Dmitry Dulepov:

> However being a core team member does not entitle to a -1 in case if
> that member does not understand what the patch does.

I assume, you do not mean with that, that I'm too stupid to understand 
your patch.

> http://typo3.org/?cHash=bogus
>
> There you get a non-cached page. Now imagine somebody putting that to an
> HTML page and waiting until Google indexes it and starts calling your
> pages with that regularly. That's the problem we had, which made a huge
> site very slow a couple of times a day for hundreds of pages. This is
> what the patch solves.

so what does your patch now want to prevent? That disabling the cache is 
triggered on a wrong cHash, or "extra cache
entries, unneeded flooding of core and RealURL caches,
useless checks." like it is mentioned in the commit message?

To prevent disabling the cache on a wrong cHash you can alread set 
pageNotFoundOnCHashError? The behaviour of course is different, because 
you get a 404 then, but isn't that exactly what you want?

> I thought it is obvious from the code. No?

Well, it is not.

What about such URL?:

http://typo3.org/?foo=bar&cHash=bogus

Your patch does not cover that.

> Do you still think it is a bad patch?

* It does not do what is mentioned in the commit message
* It only covers an edge case (bogus cHash without parameter)
* The initial problem can be solved by configuration

Still I'm not saying that it is bad. I'm kindly asking for your comments 
on that!

> No, it is not my lack of explanation. I already wrote in the first
> comment in Gerrit as a reply to Oliver: it is not about the core, it is
> about external requests. cHash in the core will be calculated correctly
> and will not do any harm. It is lack of people's wish to read explanations.

I indeed missed your comment on that, sorry.

> Again: why would I bother next time to send a fix to TYPO3?

Why would I bother to review your fixes, if you do not give me feedback 
at all, besides that it is not your fault if I do not understand your 
good patches?


Kind regards,
Helmut

-- 
Helmut Hummel
Release Manager TYPO3 6.0
TYPO3 Core Developer, TYPO3 Security Team Leader

TYPO3 .... inspiring people to share!
Get involved: typo3.org