[TYPO3-core] Change CGL for inline comments?

[Oliver Hader]

Hi Helmut,

+1

I'm all for keep it not indented in master as it is currently.
Prepending tabs for each comment does not seems to be beneficial for me.
Let's change the accordant part in the CGL - but let's keep comments in
older branches and not forcing to adjust them.

Cheers,
Olly


Am 22.09.12 18:31, schrieb Helmut Hummel:
> Hi,
> 
> our CGL currently state that inline comments must be indented one tab
> more than the following code line.
> 
> This is a speciality that only exists (as far as I know) in the TYPO3
> project for historical reasons.
> 
> One downside is, that IDEs lack support for auto formatting the comments
> that way.
> 
> With the switch to namespaces, the script accidently reverted this
> coding style and set *all* inline comments on the same indenation level
> as the following code.
> 
> During the CI code sprint we discussed if it would make sense to change
> the CGL here and leave it, as we have it now instead of fixing all the
> comments.
> 
> We all agreed that we should go that way and change the CGLs
> 
> Any major downsides to do so?
> 
> Kind regards,
> Helmut
-- 
Oliver Hader
TYPO3 v4 Core Team Leader

TYPO3 .... inspiring people to share!
Get involved: http://typo3.org