[TYPO3-core] Using lex-pass to clean up CGL issues

Arvid Jakobsson arvid.jakobsson at gmail.com
Sun Sep 9 22:39:17 CEST 2012


With the excellent guidance of Wouter I've pushed patches fixing this
CGL-issue to all sysexts except extbase and fluid to which do not have
the right to push, as far as I've understood. In the coming week we
will look into doing pushing similar fixes to the core and the
remaining sysexts.

2012/9/9 Wouter Wolters <typo3 at wouterwolters.nl>:
> First patch is on Gerrit:-)
> https://review.typo3.org/#/c/14481/
>
> Thanks Arvid!
>
> Op 9-9-2012 9:49, Arvid Jakobsson schreef:
>
>> Hi Core-developers,
>>
>> I've been modifying Facebook's lex-pass[1] to make it work with the
>> TYPO3 source code. After some modifications it seems to be working
>> fine, and I've written a rule for fixing the ("a" . "b) . "c"
>> issue[2], and also one for fixing trailing commas in Arrays. So now
>> I'm sitting on a patch with 600 modified files. Where do I go from
>> here? I push it to Gerrit? I should be able to fix other kinds of CGL
>> issues, like "false" -> "FALSE", and the comment-indentation issue.
>>
>> [1] https://github.com/facebook/lex-pass
>> [2] http://forge.typo3.org/issues/40113
>>
>> Regards, Arvid Jakobsson
>>
>
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
>
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-core


More information about the TYPO3-team-core mailing list