[TYPO3-core] Using lex-pass to clean up CGL issues

[Arvid Jakobsson]

2012/9/9 Jigal van Hemert <jigal.van.hemert at typo3.org>:
> Hi,
>
>
> On 9-9-2012 9:49, Arvid Jakobsson wrote:
>>
>> I've been modifying Facebook's lex-pass[1] to make it work with the
>> TYPO3 source code. After some modifications it seems to be working
>> fine, and I've written a rule for fixing the ("a" . "b) . "c"
>
>
> Great to have these fixed without manually going over each line!
>
>
>> I should be able to fix other kinds of CGL
>> issues, like "false" -> "FALSE", and the comment-indentation issue.
>
>
> Be careful with FALSE, TRUE and NULL. The PHP scripts also contain for
> example Javascript fragments (dynamically built JS). We've already had a
> problem in the past where false inside JS parts was changed into FALSE.

In theory this should Just Work (tm) since lex-pass works with the
abstract syntax tree of the PHP-script. Thus it makes a difference
between
 $foo = "true";
and
 $bar = true;

>
> Thanks for you efforts so far.

I'm happy to finally contribute :)

>
> --
> Jigal van Hemert
> TYPO3 Core Team member
>
>
> TYPO3 .... inspiring people to share!
> Get involved: typo3.org
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
>
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-core