[TYPO3-core] Using lex-pass to clean up CGL issues

[Helmut Hummel]

Hi Arvid,

On 09.09.12 09:49, Arvid Jakobsson wrote:

> I've been modifying Facebook's lex-pass[1] to make it work with the
> TYPO3 source code. After some modifications it seems to be working
> fine, and I've written a rule for fixing the ("a" . "b) . "c"
> issue[2], and also one for fixing trailing commas in Arrays.

Great.

> So now
> I'm sitting on a patch with 600 modified files. Where do I go from
> here? I push it to Gerrit?

Yes please. If possible, push one for each cleanup (e.g. one for [2] and 
one for trailing commas in arrays).

> I should be able to fix other kinds of CGL
> issues, like "false" ->  "FALSE", and the comment-indentation issue.

Perfekt. Looking forward to see the changes in Gerrit.

> [1] https://github.com/facebook/lex-pass
> [2] http://forge.typo3.org/issues/40113


Kind regards,
Helmut

-- 
Helmut Hummel
Release Manager TYPO3 6.0
TYPO3 Core Developer, TYPO3 Security Team Member

TYPO3 .... inspiring people to share!
Get involved: typo3.org