[TYPO3-core] CGL violations "unused parameters"

Oliver Hader oliver.hader at typo3.org
Wed Oct 24 11:56:04 CEST 2012


I totally agree with Ernesto. It does not make sense to spent too much
time on defining the excludes (I'm sure it's more then just the
DatabaseConnection) nor to check for every method whether a parameter is
used or not. The part of "backwards compat API" shows, that it's more
than just removing a parameter, since the behaviour needs to be
deprecated first.

Albeit it sounds hard, disabling this rule makes more sense for we to
get rid of those false positives...


Am 23.10.12 17:38, schrieb Ernesto Baschny [cron IT]:
> Hi,
> I would say it's not worth it. This is not a "CGL violation", as the
> unused parameters usually have some purpose:
> * backwards compatible API
> * is used in some XCLASSed code
> * is used by a subclass
> * in case of stdWrap et all, it's the TypoScript API that mandates those
> two parameters
> * etc...
> So I would rather disable this complete rule to get rid of the annoying
> messages instead of "working through" them all, which seems to be a very
> useless waste of resources.
> Cheers,
> Ernesto
> Andy Grunwald schrieb am 23.10.2012 16:55:
>> Here you will find the patch to fix this little gremmlin :)
>> https://review.typo3.org/#/c/15909/

Oliver Hader
TYPO3 CMS Core Team Leader

TYPO3 .... inspiring people to share!
Get involved: http://typo3.org

More information about the TYPO3-team-core mailing list