[TYPO3-core] CGL proposal: Dropping the closing PHP tag
Andreas Wolf
typo3ml at andreaswolf.info
Fri Nov 2 13:09:42 CET 2012
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hi Michael,
Am 22.10.2012 13:51, schrieb Michael Stucki:
> That means, you only run into problems if you have more than one
> newline after the closing tag. Why is this a problem? I don't know
> of any editor who would add more than one trailing newline to a
> file. Do you?
no, the point is that the Jenkins rule complains about *any* new line
after the trailing PHP tag. Some editors (like my local vi) add them.
It won't hurt PHP-wise, but it does with Jenkins...
Apart from that, 1+ trailing newlines will lead to errors and such an
error is really hard to track IMHO, compared to how easy we could
avoid it by just dropping the closing tag.
Regards
Andreas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iF4EAREIAAYFAlCTuAEACgkQVRefK2MMWg5pggEA1zwPExDqQbYAEGBJ6Oyx4NTH
DoGjYdFxv9ldb3fjFhQA/1kHPdVJ3mvJBcM2AzQQSFdD5F2swPtV5EJM/n7+yvou
=D9xf
-----END PGP SIGNATURE-----
More information about the TYPO3-team-core
mailing list