[TYPO3-core] Looking for reviewers to get some long pending patches through.
Bart Dubelaar
bart.dubelaar at logica.com
Wed Jun 13 10:43:32 CEST 2012
Hi,
It seems that I accidentally introduced a problem in one of the patches
myself just a few days ago. My master wasn't clean, so that's why cherry
picking failed. Sorry for that.
I have fixed that and I have fixed all comments. So please, if anyone is
willing to help out, give it a look.
Kind regards,
Bart
Bart Dubelaar wrote:
> Hi Jigal,
>
> Thanks for your reply. As far as I can see I have responded to all
> comments and created new patches if necessary.
>
> I was not aware at all that the patches were not applicable anymore.
> I am not sure how to handle the cherry picking issue. Should you monitor
> all your patches and see if they still apply on a regular basis?
> I have commited a new version of the first patch in my list only 6 days
> ago. Is that one already out of date? My repository was completely up to
> date. What is the best way to monitor this?
>
> Kind regards,
> Bart Dubelaar
>
> Jigal van Hemert wrote:
>
>> Hi,
>>
>> On 12-6-2012 10:21, Bart Dubelaar wrote:
>>> How do you mean? Why don't they apply any more?
>>
>> I'm pretty sure Georg means that it isn't technically possible to apply
>> the patch to the current master. Cherry-picking then results in loads of
>> conflicts.
>>
>> First step would then be to rebase the patch, solve the conflicts, etc.
>>
>> You will also not get many positive votes if there are valid comments
>> made by other reviewers.
>>
More information about the TYPO3-team-core
mailing list