[TYPO3-core] Problem with forge/gerrit?

Markus Klein klein.t3 at mfc-linz.at
Wed Nov 16 21:00:08 CET 2011


Ok, then it was not my fault. ;-)

But instead of fixing this in the code I'd propose the following:
- A ticket can be marked as resolved if, and only if, all patches for all assigned branches were merged. (This will also prevent that older branches are forgotten.)
- Add a rule to the Wiki (or wherever) that requires the person, who backports a merged change, to add all reviewers to the backport change sets that gave a +1 on the merged patch set.
 (This should help to get those patches faster through the reviewing process, as these persons are already familiar with the change.)

Kind regards
Markus

> -----Original Message-----
> From: typo3-team-core-bounces at lists.typo3.org [mailto:typo3-team-core-
> bounces at lists.typo3.org] On Behalf Of Steffen Gebert
> Sent: Wednesday, November 16, 2011 1:49 PM
> To: typo3-team-core at lists.typo3.org
> Subject: Re: [TYPO3-core] Problem with forge/gerrit?
> 
> Hi Markus,
> 
> > I just pushed the backports for 4.4 and 4.5 of
> http://forge.typo3.org/issues/28835 but forge/gerrit doesn’t add the links to
> these changes to the ticket.
> 
> I guess it's because this line:
>  > // if new, accepted, needs feedback, under review  > ..
>  > putIssue($updatedIssue);
> 
> I wonder why, but it seems like this never worked for already resolved
> issues? I think that can't be true..
> 
> I will have to make few adjustments to that script within the next days, so I
> will have a look at this one, too.
> 
> Kind regards
> Steffen
> 
> --
> Steffen Gebert
> TYPO3 v4 Core Team Member
> TYPO3 Server Administration Team Member
> 
> TYPO3 .... inspiring people to share!
> Get involved: http://typo3.org
> _______________________________________________
> Before posting to this list, please have a look to the posting rules on the
> following websites:
> 
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-core



More information about the TYPO3-team-core mailing list