[TYPO3-core] Bug in Gerrit

Ernesto Baschny [cron IT] ernst at cron-it.de
Wed Mar 30 10:08:14 CEST 2011


Markus Klein schrieb am 30.03.2011 08:52:

> Please, can a gerrit pro take a look at this issue:
> https://review.typo3.org/#change,1317
> 
> There seems to be a serious problem with diff viewing when applying
> changes to the bottom of a file. (having no newline at the end)
> 
> The patch is ok, but the diff view doubles the last line of base.

Yes, this seems indeed to be a bug in Gerrit's diff viewer. Anyway I
checked this particular review request, and have already pushed it to
master - after adding [TASK] and the Resolves: tag in the commit msg -
and also backported it to 4.5.

Thanks!

Cheers,
Ernesto



More information about the TYPO3-team-core mailing list