[TYPO3-core] Bug in Gerrit

[Markus Klein]

Thx for posting the bug!

Kind regards
Markus

> -----Original Message-----
> From: typo3-team-core-bounces at lists.typo3.org [mailto:typo3-team-core-
> bounces at lists.typo3.org] On Behalf Of Björn Pedersen
> Sent: Wednesday, March 30, 2011 8:58 AM
> To: typo3-team-core at lists.typo3.org
> Subject: Re: [TYPO3-core] Bug in Gerrit
> 
> Am 30.03.2011 08:52, schrieb Markus Klein:
> > Hello!
> >
> >
> >
> > Please, can a gerrit pro take a look at this issue:
> > https://review.typo3.org/#change,1317
> >
> > There seems to be a serious problem with diff viewing when applying
> > changes to the bottom of a file. (having no newline at the end)
> >
> > The patch is ok, but the diff view doubles the last line of base.
> >
> >
> >
> > In this case the following is shown:
> >
> > }
> >
> > +}
> >
> > +?>
> >
> >
> >
> > Whereas the patch says:
> >
> > -}
> >
> > \ No newline at end of file
> >
> > +}
> >
> > +?>
> >
> > \ No newline at end of file
> >
> >
> >
> >
> >
> > Kind regards
> >
> > Markus
> >
> >
> >
> >
> 
> There seems to be a off-by-one error:
> See also:
> http://forge.typo3.org/issues/25444
> 
> Björn
>