[TYPO3-core] XLIFF patches

Xavier Perseguers xavier at typo3.org
Mon Jun 13 18:16:43 CEST 2011


Hi,

> to easier keep track, I'd start a thread here. I'm talking of
> https://review.typo3.org/#change,2572,patchset=8
>
> * The name of the classes is good now. IMHO 2572 is pretty ready. Except

Yes.

> * ExtJS modules have to be fixed

+1

> * Recycler is broken in the last patch set (I think it worked in some
> earlier version). JS error: Uncaught TypeError: Object [object Object]
> has no method 'replace' (probable the known [object] problem?).

I have the feeling both are related...

> * The changes for Extbase have to be pushed separately (this means that
> also from https://review.typo3.org/2573 the xlf file has to be removed
> and pushed to Extbase review separately. This has to be done by
> Dominique himself, and he has to sign the CLA (as I assume the CLA
> prohibit to push code from other people).

I had understood that one could push it but I may have missed something, 
otherwise writing patches for Extbase/Fluid without having the CLA 
signed would not make sense and the work from the community in general 
would be lost. For sure one has to have sign the CLA to push to Gerrit 
but I'm sure the one who wrote the patch not (what is possible is that 
in such cases the author cannot be mentioned though).

> * I'm still not sure, at which places backwards compatibility is broken.
> Extbase modules (workspaces) crash (without the required change for
> extbase:
> https://review.typo3.org/#patch,unified,2572,1,typo3/sysext/extbase/Classes/Utility/Localization.php).
> But how does this impact other extensions dealing with
> $GLOBALS['LOCAL_LANG']?

I'd say that we know we want to go in that direction. The work on XLIFF 
is not finished yet, if some (not all of course :D) non-Core extensions 
are broken because of edge-cases play with the API or simply because 
some parts are not yet ready (support for deprecated LLPHP files for 
instance), that's not that bad from my POV, we have a developer snapshot 
tomorrow (alpha2) and we will fix them until alpha3.

Cheers

-- 
Xavier Perseguers
Release Manager TYPO3 4.6

TYPO3 .... inspiring people to share!
Get involved: http://typo3.org



More information about the TYPO3-team-core mailing list