[TYPO3-core] Gerrit Workflow with changing patchsets

Peter Niederlag typo3-list at niekom.de
Thu Jul 28 15:54:50 CEST 2011


> on one hand it's a good practice to split bigger commits in multiple
> parts, since it's easier to review, on the other hand it might be
> annoying to update all dependant changes after pushing a patchset to a
> preceeding commit.
> Maybe it's easier if I'm more used to it...

I am not sure, but it seems gerrit is just not optimal suited for 
"stacks of change-requests"(?). For example if there is a stack of ten 
change-requests which depend on each other: ALL reviews get lost, when 
the first patchset is updated, as in consequence all other (stacked) 
change requests have to be updated and thus loose their review status.

I guess you could optimize/automize some toolchain around 'git rebase' 
that goes through a series of patches, fetches the most recent patch 
version from gerrit and updates the stack on top of it.

Also there are patches/issues around gerrit that try to build some kind 
of support to group change-requests, however IMO nothing that will be 
nativly supported in the near future.

Maybe the other folks around (flow3?) have something else to add. ;)


Peter Niederlag
http://www.niekom.de * TYPO3 & EDV Dienstleistungen *

More information about the TYPO3-team-core mailing list