[TYPO3-core] RFC #12230: Bug: Function tslib_cObj::crop() is not fully multibyte safe

JoH asenau info at cybercraft.de
Mon Jan 31 16:23:09 CET 2011


> +1 for the check of length with csconvobj.
>
> -1 on changing the concatination in a ternary. There is no improvement
> by putting the hole in one line. Neither does it improve readbility nor
> any performance.

Actually the ternary is in the current code and the patch replaces it 
with if/else - so I don't see the problem here.

+1 by reading.

Joey

-- 
Wenn man keine Ahnung hat: Einfach mal Fresse halten!
(If you have no clues: simply shut your gob sometimes!)
Dieter Nuhr, German comedian
Xing: http://contact.cybercraft.de
Twitter: http://twitter.com/bunnyfield
TYPO3 cookbook (2nd edition): http://www.typo3experts.com


More information about the TYPO3-team-core mailing list