[TYPO3-core] RFC #17284: Formprotection persistToken method is called too often, causing unnecessary DB-load

[Helmut Hummel]

Hi Rupi,

Am 25.01.2011 10:14, schrieb Rupert Germann:

> +1 by reading, testing and profiling
>
> the number of queries for displaying the db listmodule in my
> testinstallation is reduced by ~30%
>
> great!

Thanks for bringing up that topic.

The root cause of this problem was a persistTokens call in 
TBE_TEMPLATE->issueCommand() which then persisted all tokens for every 
action url that was generated by this method. This was a leftover from 
the testing phase, which I simply forgot.

Now that Steffen came up with the idea TBE_TEMPLATE->endPage() beeing a 
central exit point for all scripts, the tokens only get persisted once 
(with one exception beeing the user setup due to the simuser feature).

Kind regards,
Helmut

-- 
Helmut Hummel
TYPO3 Security Team Leader

TYPO3 .... inspiring people to share!
Get involved: typo3.org